Open
Conversation
The previous method used hardcoded firmware paths to load the firmware from disk. That works if the driver is built as a module but does not work if baked in. The proper way to load firmware is with request_firmware which handles both file loading and blobs.
Owner
|
afaik mt76_get_eeprom_file should not be called from mt76_get_of_eeprom and leave the check. the node must be checked when loading from devicetree, but file does not need the mt76 node...so the logic has to be changed. the changes above are because changing kernel_read to request_firmware? patch works for you without crashes, also when file does not exist? |
Author
|
I've not tested it when the file does not exist, I could test that but it should not crash, It would just default back to the missing firmware behavior (The behavior i was experiencing before this) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous method used hard coded firmware paths to load the firmware from disk. That works if the driver is built as a module but does not work if baked in.
The proper way to load firmware is with request_firmware which handles both file loading and blobs.
I also noticed that the mt76_get_eeprom_file function wasn't getting called at all due to a seemingly unused variable?
Likely a leftover from previous code.
Either way commenting it out seems to work.
I've tested firmware blob loading (baked into the kernel) and that seems to work, Regular file loading should also still work but i've not tested it.